fix: closing of previous release PRs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparten11740
changed the base branch from
sparten11740/refactor/unsafe-exec-usage
to
master
sparten11740
force-pushed
the
sparten11740/fix/closing-of-previous-prs
branch
from
66051e8 to
cfcc441
Compare
mvayngrib
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing previous release PRs releasing the same packages breaks when labels other than the package names to be released and the
RELEASE_PR_LABELare present on it. This makes sure we only consider package name labels when checking if a PR should be closed.Closes #29
Testplan
Tested in https://github.com/ExodusMovement/lerna-version-selectively/pull/467