This repository has been archived by the owner on Jan 19, 2025. It is now read-only.
[EXILED::EVENTS] Fixing bug report n.396
#2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
regarding-events
xNexusACS
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Fixes https://git.scpslgame.com/northwood-qa/scpsl-bug-reporting/-/issues/396
What is the current behavior? (You can also link to an open issue here)
Games just takes the first Scenario, 120 seconds and just uses that if the value is not the same as one of the scenarios
What is the new behavior? (if this is a feature change)
Takes the nearest number from the Scene loaded from the game
Just as it showing i replicated the issue from the report but fixing it and showing the default game behavior
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Shouldn't
(I've checked if in the config or in some way is changed but doesn't seem)
Other information:
The code is big and a mess because SL doesn't let me change directly the network info so i need to take the default one and then change it and forgot to say that SL has no value for the configfile so i took it manually
Like im showing here the game does that
(Not 100% this works i didn't test it in game to see if the cassie replies correctly but it seems ok by showing)
This shows how the Logs where done
(I'm lazy so i copied everything from the PR on the other repo)