HintModule #2728
HintModule #2728
Conversation
# Conflicts: # Exiled.Events/Extra/CoroutineManager.cs # Exiled.Events/Extra/Events/EventGroup.cs # Exiled.Events/Extra/Events/EventScanner.cs # Exiled.Events/Extra/FeatureGroup.cs
github-actions
bot
added
regarding-api
|
... If this is allowed to be tested, I'm gonna throw. The main issue is that it doesn't match the styling of the rest of the project structure. |
| this.Content = content; | ||
| this.Duration = duration; | ||
| this.Show = show; | ||
| this.Parameters = parameters ?? new HintParameter[] { new StringHintParameter(this.Content) }; |
| get => parameters ??= new HintParameter[] { new StringHintParameter(Content) }; | ||
| set => parameters = value; | ||
| get => this.parameters ??= new HintParameter[] { new StringHintParameter(this.Content) }; | ||
| set => this.parameters = value; |
| @@ -87,6 +87,6 @@ public HintParameter[] Parameters | |||
| /// Returns the hint in a human-readable format. | |||
| /// </summary> | |||
| /// <returns>A string containing hint-related data.</returns> | |||
| public override string ToString() => $"({Content}) {Duration}"; | |||
| public override string ToString() => $"({this.Content}) {this.Duration}"; | |||
| } | |||
| return; | ||
| TextHint hint = new TextHint(hintText, [new StringHintParameter(hintText)], null); | ||
| connectionToClient.Send(new HintMessage(hint)); | ||
| } |
There was a problem hiding this comment.
make sure to leave a blank line after the returns and the new InvalidOperationException
| Tuple<Hint, List<Player>, long> item = hints[se]; | ||
| if (!item.Item2.Contains(keyValuePair.Key)) | ||
| continue; | ||
| if ((item.Item3 - DateTimeOffset.UtcNow.ToUnixTimeSeconds()) > item.Item1.Duration) |
There was a problem hiding this comment.
same here for the continue up here
| using RueI.Elements; | ||
| using RueI.Parsing; | ||
| using RueI.Parsing.Records; | ||
|
|
There was a problem hiding this comment.
all of this should be with the other ones, also why using 2 Hints Namespaces
| <Generator>ResXFileCodeGenerator</Generator> | ||
| <LastGenOutput>Resources.Designer.cs</LastGenOutput> | ||
| </EmbeddedResource> | ||
| </ItemGroup> |
| public override void OnEnabled() | ||
| { | ||
| harmony = new Harmony("exiled.hints"); | ||
| if (CustomHints.OnEnabled.BoundDelegates.ContainsKey(this)) return; |
| private void OnModuleDisable(ModuleInfo info) | ||
| { | ||
| harmony.UnpatchAll(); | ||
| } |
There was a problem hiding this comment.
harmony.UnpatchAll(harmony.Id)
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0.0")] |
There was a problem hiding this comment.
the assemblyinfo is not needed here.
| @@ -282,7 +282,7 @@ private set | |||
| /// <summary> | |||
| /// Gets the <see cref="Hints.HintDisplay"/> of the player. | |||
| /// </summary> | |||
| public HintDisplay HintDisplay { get; private set; } | |||
| public Hints.HintDisplay HintDisplay { get; private set; } | |||
|
We got a plugin in Exiled before GTA VI Seriously, this is a bad idea. This is just a copy and paste of Ruei, what's the point. And you can just use Ruei in this case. Rue even said no to take any part of their plugin, but you did it anyway. You said you were just "taking the parser of Ruei" but this is a full copy and paste, what is this. This is the worst idea to implement into Exiled |
|
@Ruemena lmao |
Added a hint module, allowing without any modifications to any plugins, multiple hints to be displayed concurrently. Supports all rich text tags and uses patches, can be enabled and disabled at will. Utilizes RueI code (license permits)