Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundary plane regression test #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Nov 27, 2024

Need to make sure this important capability is covered. The uniqueness of the file reads and using the overset solver make it prone to being accidentally broken.

Should follow after the merge of Exawind/amr-wind#1358

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 27, 2024

I made this by copying amr-wind regression tests and putting a nalu-wind box in there. Open to any tweaks that would make this make more sense as an actual case, rather than just something that accomplishes the required coverage. Just in case it gets reused as an example in the future.

@marchdf
Copy link
Contributor

marchdf commented Nov 27, 2024

I like this idea. I am fine it being a dummy nalu-wind box. Thank you for doing this.

@mbkuhn mbkuhn requested a review from itopcuoglu December 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants