Component | Graph: Fixing pointer-events issues; Configurable link highlight on hover #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lector This commits aims to solve frequent problems with node mouseover / click events not being triggered (link events were triggered instead). - Adds a new `linkLabel` selector to the Graph component to target the link label group - Removes the `pointer-events: all` style from the `linkLabelGroup` to prevent link hover highlight from interfering with link label interactions
- Adds a new `linkHighlightOnHover` config option to the Graph component to enable/disable link hover highlight - Updates the `_onLinkMouseOver` method to only set the `hovered` state if `linkHighlightOnHover` is true
rokotyan
requested review from
ankursingla and
a team
and removed request for
a team and
ankursingla
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Graph component had frequent pointer-events related issues when hovering over nodes or clicking on them. This PR should fix this problem.
Also, adding a config option
linkHighlightOnHoverallowing to disable link highlighting on hover (defaults totrueto avoid breaking changes)388450083-20d4ca2d-92ba-4a74-b962-fe48e9aeeb80.mp4