Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed old style particle loops #256

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

removed old style particle loops #256

wants to merge 9 commits into from

Conversation

will-saunders-ukaea
Copy link
Contributor

@will-saunders-ukaea will-saunders-ukaea commented Sep 24, 2024 •
edited
Loading

Description

  • PR to remove the old style particle loops from NESO.
  • Leaves the old style particle loop in CellIDTranslation as that is updated in the composite interaction PR.
  • Leaves the Bary function evaluation loop as that requires local memory and there is not an abstraction for that.

Waiting on #223 to avoid reimplementing fixes in that PR.

@will-saunders-ukaea will-saunders-ukaea added the work in progess Draft PR - not to merge! label Sep 24, 2024
@will-saunders-ukaea will-saunders-ukaea changed the title removed old style particle loops from tests removed old style particle loops Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progess Draft PR - not to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@will-saunders-ukaea