Implicit implementation of 2Din3D Hasegawa-Wakatani #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f for some reason.
17 tasks
| @@ -250,12 +251,12 @@ class NeutralParticleSystem { | |||
| std::vector<int> components = {0}; | |||
| m_field_project->project(syms, components); | |||
| if (m_low_order_project) { | |||
| FieldUtils::Interpolator interpolator{}; | |||
| FU::InterpolatorSharedPtr interpolator; | |||
There was a problem hiding this comment.
Does this need a make_shared to actually call the constructor?
There was a problem hiding this comment.
Yep
Think I'll change it to what you have in #234 anyway - no real need for a shared pointer here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implicit implementation of 2Din3D Hasegawa-Wakatani. Adapted from code in nektar-driftwave.
Requires nektar main at or after 8bc4b3095361e868b26219eff826d4f1902763df (07/03/2024).
Fixes #229
Type of change
Testing
Add test - to do.
Test Configuration:
OS: Ubuntu 22.04
Compiler: GCC 11.3.0 / OneAPI v2022.1.0
SYCL implementation: Hipsycl v0.9.2 / DPC++ v2022.1.0
MPI details: MPICH v4.0.2
Hardware: CPU (Intel Alder Lake)
Checklist:
clang-formatagainst my*.hppand*.cppchanges