fix #1481: исправлено Вычислить() с именами параметров процедуры +тест

[Mr-Rm]

Было сломано в PR#1439

Summary by CodeRabbit

• New Features

  • Added a new test procedure to verify parameter handling in procedures
  • Enhanced testing capabilities for dynamic parameter evaluation

• Tests

  • Introduced new test case to validate procedure parameter functionality

[coderabbitai]

Walkthrough

The pull request introduces a subtle modification to the CreateReference method in the Variable class within the OneScript.Core project. The change refines the conditional logic for creating variable references, specifically enhancing the type checking mechanism. Simultaneously, a new test procedure is added to eval.os to validate parameter handling and dynamic evaluation capabilities, expanding the testing suite with a procedure that demonstrates dynamic parameter manipulation.

Changes

File	Change Summary
src/OneScript.Core/Contexts/Variable.cs	Refined conditional check in CreateReference method for VariableReference type validation
tests/eval.os	Added two new procedures: РаботаСПараметрамиПроцедуры and ТестДолжен_ПроверитьРаботоспособностьСПараметрамиПроцедуры for testing parameter handling

Sequence Diagram

sequenceDiagram
    participant Procedure as РаботаСПараметрамиПроцедуры
    participant Evaluator as Вычислить
    participant Test as ТестДолжен_ПроверитьРаботоспособностьСПараметрамиПроцедуры
    
    Test->>Procedure: Call with structured parameters
    Procedure->>Evaluator: Dynamically access parameters
    Procedure-->>Test: Return concatenated result

Loading

Poem

🐰 Rabbit's Code Refrain 🐰

In variables' dance, a subtle twirl,
Conditions refined, logic unfurl
Parameters bounce with dynamic might
Testing the bounds of code's delight
A rabbit's whisper of logic so neat! 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/eval.os (1)

346-352: Validate dynamic parameter usage.
Concatenating the values of Элемент1 and Элемент2 via Вычислить("Элемент" + Сч) in a loop tests the dynamic parameter handling effectively. Consider adding a negative or boundary test case where parameters might be empty or of different types, to confirm robust error handling.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71ccd4f and 2d19904.

📒 Files selected for processing (2)

• src/OneScript.Core/Contexts/Variable.cs (1 hunks)
• tests/eval.os (2 hunks)

🔇 Additional comments (4)

src/OneScript.Core/Contexts/Variable.cs (2)

35-37: Clarify exception handling for invalid indexes.
Accessing iv.Value forces evaluation of the indexed property. If the index is invalid (e.g., out of bounds), an exception might be thrown here. Ensure that this behavior is intended and that exceptions are properly handled or surfaced to the caller.

---

39-39: Confirm no unintended side effects.
After the conditional block, a new VariableReference is always returned. Make sure that, if iv.Value raised an exception, the code’s desired fallback or error handling behavior is properly implemented.

tests/eval.os (2)

28-28: Well-documented addition to the test suite.
Adding ТестДолжен_ПроверитьРаботоспособностьСПараметрамиПроцедуры to the test list expands coverage for Вычислить with dynamically accessed parameters. This is a good practice to ensure the fix is validated.

---

354-356: Effective test procedure.
The structure passed into РаботаСПараметрамиПроцедуры ensures reliable coverage of the new functionality. Good job verifying the result is "Поле1Поле2". If future logic changes, consider adding checks for alternative input scenarios.

[EvilBeaver]

Спасибо!