Prevent leftovers MenuButtons when rebuilding menu #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie480
added
the
needs fixing
|
needs resolving conflicts (and I apparently can't do it myself) |
DashingCat
force-pushed
the
430-prevent-leftovers-menubuttons
branch
from
3e3b39f to
795180c
Compare
|
Thanks for the heads up, conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer
RebuildMainAndTitle()right beforeUpdate(), soCreateButtons()is only called once per frame.When
CreateButtons()is called more than once per frame, it creates orphaned buttons (not linked to theOuiMainMenu) which are not cleaned up properly, causing selection issues in the main menu.The method
RebuildMainAndTitle()is nowprivateto prevent direct usage.Closes issues #430 (and #766 which is a duplicate)