Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESDB-174-4] Separate third party notices into NOTICE.md #51

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

timothycoleman
Copy link
Contributor

@timothycoleman timothycoleman commented Aug 15, 2024

This is the standard practice.

This PR does not audit/alter the content of the notices, just moves them.

We continue to include the notices in the nuget package because it is nice to give attribution even though the nuget package doesn't contain the 3rd party code or binaries

Copy link

github-actions bot commented Aug 15, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 8 dependencies

Third-party software list

This page lists the third-party software dependencies used in EventStore.Plugins

Dependency Version Licenses
JetBrains.Annotations 2023.3.0 MIT
Microsoft.IdentityModel.Abstractions 7.6.0 MIT
Microsoft.IdentityModel.JsonWebTokens 7.6.0 MIT
Microsoft.IdentityModel.Logging 7.6.0 MIT
Microsoft.IdentityModel.Tokens 7.6.0 MIT
System.Diagnostics.DiagnosticSource 8.0.1 MIT
System.Reactive 6.0.1 MIT
YamlDotNet 15.1.4 MIT
Contact Qodana team

Contact us at [email protected]

@timothycoleman timothycoleman force-pushed the timothycoleman/separate-license-notices branch 2 times, most recently from 14aaeb5 to 991351e Compare August 15, 2024 10:41
@timothycoleman timothycoleman changed the title Separate third party notices into NOTICE.md [ESDB-174-4] Separate third party notices into NOTICE.md Aug 15, 2024
@timothycoleman timothycoleman changed the base branch from master to timothycoleman/add-qodana-configuration August 15, 2024 11:49
@timothycoleman timothycoleman force-pushed the timothycoleman/add-qodana-configuration branch from e206a91 to a97a92b Compare August 19, 2024 11:21
This is the standard practice.

This PR does not audit/alter the content of the notices, just moves them.

We continue to include the notices in the nuget package because it is
nice to give attribution even though the nuget package doesn't contain
the 3rd party code or binaries
@timothycoleman timothycoleman force-pushed the timothycoleman/separate-license-notices branch from 991351e to ccb6111 Compare August 19, 2024 11:22
Base automatically changed from timothycoleman/add-qodana-configuration to master August 19, 2024 11:29
@hayley-jean hayley-jean merged commit dcd271a into master Aug 19, 2024
4 checks passed
@hayley-jean hayley-jean deleted the timothycoleman/separate-license-notices branch August 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants