Update default persistent subscription settings to match TCP client #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
previously approved these changes
Jun 16, 2021
YoEight
previously approved these changes
Jun 16, 2021
hayley-jean
force-pushed
the
update-persistent-subs-defaults
branch
4 times, most recently
from
85df496 to
5da276d
Compare
YoEight
previously approved these changes
Jun 24, 2021
hayley-jean
force-pushed
the
update-persistent-subs-defaults
branch
11 times, most recently
from
72ec850 to
1c27014
Compare
YoEight
previously approved these changes
Jul 12, 2021
Changes to Test Issue 1125: - Don't increment received events if they were retries. - Set the read batch size to 10 as having this set to 20 increases the chance of a duplicate event 250 being received.
hayley-jean
force-pushed
the
update-persistent-subs-defaults
branch
from
1c27014 to
558e842
Compare
thefringeninja
approved these changes
Jul 14, 2021
YoEight
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the defaults don't match the TCP client's while updating persistent subscription docs.
Change the defaults for the following settings when creating a Persistent Subscription:
The Issue 1125 test fails with these new defaults. I've created an issue to investigate this here: #139