-
Notifications
You must be signed in to change notification settings - Fork 64
Add Detailed Daily Conference Schedule #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ep2025
Are you sure you want to change the base?
Conversation
Preview available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the highlight, or preferably highlight the current day during the conference (which could be a separate PR).
It also sticks out as "Sprints" and not day names ("Saturday-Sunday"), compared to the others which don't tell you what's happening.
Either use day names for all, or day names plus content for all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let's use Saturday & Sunday
- content is in the section above, so I would not repeat it
--- | ||
|
||
<Section> | ||
<Headline as="h5" title="Detailed Daily Conference Schedule" center="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be more concise -- we can see its daily, and nearly everything on this site relates to the conference:
<Headline as="h5" title="Detailed Daily Conference Schedule" center="true" /> | |
<Headline as="h5" title="Detailed Schedule" center="true" /> |
))} | ||
|
||
<Button url={sprints.href} secondary class="schedule-box"> | ||
{sprints.day}<br />{sprints.dayname} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the highlight, or preferably highlight the current day during the conference (which could be a separate PR).
It also sticks out as "Sprints" and not day names ("Saturday-Sunday"), compared to the others which don't tell you what's happening.
Either use day names for all, or day names plus content for all?
Co-authored-by: Mia Bajić <[email protected]>
Related issue #1292
suggestion of day by day links to schedule