Country selector #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 11, 2017 14:40
As PushRow<String> in order to allow country selection instead of a textField
This allows us to initialize an empty object of the PostalAddressType used - instead of the non-generic implementation. We also made sure the onChange event is only fired once - and not multiple times (this was the case if the PostalAddress value was not initialized before).
Because the onChange event of the PushRow was not fired, the child cell was never reloaded and therefore displayed a wrong state.
Still waiting for a new tagged release though
|
Any chance we can get this merged? |
mats-claassen
requested changes
Mar 2, 2018
| @@ -1 +1 @@ | |||
| github "xmartlabs/Eureka" ~> 4.0 | |||
| github "xmartlabs/Eureka" "master" | |||
|
|
||
| +++ Section() | ||
| <<< MyPostalAddressRow() { | ||
| $0.streetPlaceholder = "Street" |
There was a problem hiding this comment.
Could you align this line to its context? Maybe if you set Xcode to replace tabs with spaces
| @IBOutlet weak var postalPercentageConstraint: NSLayoutConstraint? | ||
|
|
||
There was a problem hiding this comment.
Please remove trailing whitespace
| @@ -61,6 +66,8 @@ open class _PostalAddressCell<T: PostalAddressType>: Cell<T>, CellType, PostalAd | |||
| cityTextField?.removeTarget(self, action: nil, for: .allEvents) | |||
| countryTextField?.delegate = nil | |||
| countryTextField?.removeTarget(self, action: nil, for: .allEvents) | |||
| countrySelectorTableView?.delegate = nil | |||
There was a problem hiding this comment.
Same here for indentation.
|
Hi @marbetschar, sorry for the late reply. Why did you use a UITableView with a PushRow instead or a simple button that pushes a SelectorViewController? |
|
@mats-claassen main idea was to provide a way for further customization, using native Eureka features .... but looking back it might not made too much sense probably...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to define a country selector using the newly added
var countrySelectorRow : PushRow<String>?as discussed in #3.To make use of this you'll define a
PostalAddressRowlike this (see the Example project):If you want to use custom Nibs, you'll have to add a
UITableViewlinked with@IBOutlet open var countrySelectorTableView: UITableView?.And this is how it looks like: