Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenSSH certificate authentication #366

Closed
wants to merge 3 commits into from

Conversation

Nathy-bajo
Copy link
Contributor

I added support for OpenSSH certificates to the server-side authentication. This includes:

  • Certificate Parsing: A new function to parse certificate data, extracting key details like validity, key ID, and signature.

  • PublicKey Enum Extension: A Certificate variant added to the PublicKey enum, representing certificate-based keys.

  • Certificate Validation: Updated the authentication flow to check certificate validity and verify signatures before proceeding with authentication.

These changes enable the server to authenticate users using standard public keys and OpenSSH certificates.

@Eugeny
Copy link
Owner

Eugeny commented Oct 30, 2024

Thank you for the PR! I've decided to take it one step further and use ssh-key wherever possible - check it out in #368, I'd appreciate a quick test

@Eugeny
Copy link
Owner

Eugeny commented Oct 30, 2024

@all-contributors add @Nathy-bajo for code

Copy link
Contributor

@Eugeny

I've put up a pull request to add @Nathy-bajo! 🎉

Eugeny pushed a commit that referenced this pull request Oct 31, 2024
Adds @Nathy-bajo as a contributor for code.

This was requested by Eugeny [in this
comment](#366 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@Eugeny
Copy link
Owner

Eugeny commented Nov 3, 2024

Merged as a part of the ssh-key migration!

@Eugeny Eugeny closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants