feat(wasm): Add util creates for runtime,future and time primitives for wasm #350
+232
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eugeny
requested changes
Sep 20, 2024
| /// | ||
| /// This type lets you replace the future stored in the box without | ||
| /// reallocating when the size and alignment permits this. | ||
| pub struct ReusableBoxFuture<'a, T> { |
| @@ -0,0 +1,16 @@ | |||
| use std::future::Future; | |||
|
|
|||
| pub fn spawn<F>(future: F) | |||
There was a problem hiding this comment.
This needs to be generic over Output as well, as it's used in various places. I prefer this PR to include the migration of russh and russh-keys over to the generic runtime before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second pull request for supporting WASM.
Introducing russh-util crates to encapsulate platform difference.
Prepare for replacing tokio-util, tokio runtime and std::time::Instant::now.