Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update relevant channel request callbacks to return a bool #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update relevant channel request callbacks to return a bool #348

wants to merge 1 commit into from

Commits on Sep 19, 2024

  1. Update relevant channel request callbacks to return a bool 

    This is a breaking change, but it tweaks channel request callbacks to
return a bool rather than requiring the user to manually call
`session.channel_success` or `session.channel_failure`.

This has the added advantage of changing the defaults of a number of
request callbacks to more-secure defaults (deny), and makes it
impossible for a user to miss responding to callbacks which require
responses.

Note that this does *not* handle sending responses for all requests,
only channel requests listed in RFC4254 as having a "want reply" param
rather than just "false", even though it may be more correct to respond
to malformed requests which have improperly set that byte to "true" even
though the RFC specifies "false".
    @belak
    belak committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    144f58a View commit details
    Browse the repository at this point in the history