Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ChannelMsg::WindowAdjusted during data transfer #180

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

jgrund
Copy link
Contributor

@jgrund jgrund commented Sep 12, 2023

OpenSSH server sends CHANNEL_WINDOW_ADJUST messages before window_size is 0.

Handle these messages at each turn of the loop within Channel.send_data

Fixes #179

OpenSSH server sends `CHANNEL_WINDOW_ADJUST` messages before window_size is 0.

Handle these message at each turn of the loop within `Channel.send_data`

Signed-off-by: Joe Grund <[email protected]>
@Eugeny
Copy link
Owner

Eugeny commented Sep 20, 2023

Just a heads-up - I've reverted your PR in favour of #181. There's nothing wrong with your PR - just that #181 includes more robust handling in case of multiple parallel writers and other improvements ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

many ChannelMsg::WindowAdjusted messages buffered during large data transfer
2 participants