Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #169

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Update dependencies #169

merged 1 commit into from
Aug 2, 2023

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Aug 2, 2023

Notes:

  • It seems appropriate to just unwrap the result of pbkdf2 since I assume it was previously just panicking internally on such a case.
  • bitflags 2.0 now automatically implements IntoIterator, removing the need for manually implementing Iterator. It also requires us to Derive a bunch of traits ourselves that used to be done automatically.
  • a change in curve25519-dalek resulted in a previous double reference failing to automatically dereference. Not sure why that is but changing it to a single reference makes more sense anyway.
  • I left the rand in russh-keys as is because that version of rand is used in the ed25519-dalek api.

@Eugeny
Copy link
Owner

Eugeny commented Aug 2, 2023

I'd rather not have that .unwrap() since it relies on the implementation detail of Hmac:: new_from_slice never returning an error even though it returns Result

@rukai
Copy link
Contributor Author

rukai commented Aug 2, 2023

alright, I backed out the pbkdf2 changes since I'm not sure how to handle that properly, it can be done by someone else.

@Eugeny Eugeny merged commit 5d82dcb into Eugeny:master Aug 2, 2023
3 checks passed
@rukai rukai mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants