GH-219 Add option to display milliseconds for last second of combat

[CitralFlo]

DurationUtil method for millis was not used before

[coderabbitai]

Walkthrough

This update introduces a new setting that lets users choose whether to show milliseconds or just seconds in combat notifications. A new option called withoutMillis was added to the configuration. The code that formats and displays the remaining combat time now checks this setting to decide how to show the time. There was also a small fix to a message string to correct a formatting tag. The method that formats the duration was updated so it uses the right format based on the new setting, ensuring the time is shown as intended in different situations. No public interfaces or method signatures were changed.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8b48b8 and b02158f.

📒 Files selected for processing (3)

• eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/MessagesSettings.java (2 hunks)
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/FightTask.java (1 hunks)
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/util/DurationUtil.java (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/FightTask.java (1)

eternalcombat-plugin/src/main/java/com/eternalcode/combat/util/DurationUtil.java (1)

• DurationUtil (9-50)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (4)

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/FightTask.java (1)

48-48: Nice update to use configuration setting!

You're now correctly passing the withoutMillis setting to the format method, which enables the display of milliseconds in the last second of combat.

eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/MessagesSettings.java (2)

32-35: Good configuration option addition

The new setting allows users to control millisecond display for combat timers.

---

63-63: Fixed formatting tag

You removed an unnecessary closing tag that was causing formatting issues.

eternalcombat-plugin/src/main/java/com/eternalcode/combat/util/DurationUtil.java (1)

40-43: Clean implementation of milliseconds display

Your changes properly handle showing milliseconds only during the last second of combat (when duration is ≤ 1 second and removeMillis is false).

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.