Add support for AsyncChatEvent in Paper server #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've found a little bug when receiving the AsyncChatEvent synchronously (I didn't know that was possible). I'm fixing it. |
|
Fixed, it should work now. |
Euphillya
suggested changes
Aug 19, 2024
.../PaperProvider/src/main/java/net/ess3/provider/providers/PaperAsyncChatListenerProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #5243.
Details
Proposed fix:
Since the EssentialsDiscord plugin only listens to AsyncPlayerChatEvent, which
is called before calling AsyncChatEvent, any changes made to the message in the
latter event will be ignored by the plugin.
In order to fix it, I've added some classes to the PaperProvider and a new async
event which will be called each time an AsyncChatEvent is received.
The plugin checks if the AsyncChatEvent exists and registers the two listeners
needed instead of the bukkit one.
Environments tested:
OS: Ubuntu 24.04 LTS
Java version: Oracle GraalVM 21.0.3+7.1
Demonstration: