Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add give argument to skull command #5822

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

Yurakaii
Copy link

@Yurakaii Yurakaii commented Jun 5, 2024

Information

This PR closes #5762.

Details

Proposed feature:
This adds the ability to give a skull to another player using the /skull command with a second argument, if you only provide one argument the command will work as it previously did.

The new usage of the skull command is:
/<command> [owner] [player]

Environments tested:

OS: Windows 11

Java version: 21

  • Most recent Paper version (1.20.6, git-Paper-137)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

This gives the dinnerbone's skull to trashdrumlinfly:
Screenshot 2024-06-05 144150

trashdrumlinfly received dinnerbone's skull
Screenshot 2024-06-05 143929

The command can still be used as how it worked before by just providing the first argument.

Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks fine, can you just update the skullCommandUsage messages in the messages.properties file

@Yurakaii Yurakaii marked this pull request as draft July 23, 2024 21:14
@Yurakaii Yurakaii marked this pull request as ready for review July 23, 2024 21:30
@Yurakaii Yurakaii requested a review from JRoy July 23, 2024 21:32
@CatBang

This comment was marked as spam.

@Huge-mistake
Copy link

overall looks fine, can you just update the skullCommandUsage messages in the messages.properties file

Apologies for the interruption, can this PR be merged now? I would like to utilize this feature in the menu to provide players with skulls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to give someone their skull using /skull [player/skin] [player]
4 participants