Fix for issue raised on the rtree

[seanmalter]

Description

This pull request is to fix the issue found and noted in #4. To resolve the issue the overlap_rectangle function will now consider a rectangles with equal sides as overlapping.

[jgravois]

thanks for this patch @seanmalter 👍. just out of curiosity, what version of Node.js did you use to run the tests?

i saw errors yesterday, even on 6.x.

[seanmalter]

@jgravois I'm using 8.12.0. I did have to modify the test cases so that geojson that are on the edges of the rectangle are considered. I'm a little hesitant of these changes and actually think that we might want to make a new Rectangle.inclusive_overlap_rectangle that has the changes needed for _remove_subtree so we don't lose any functionality and do not alter the current .within workflow. Any thoughts @jgravois ?

[seanmalter]

@jgravois added a new function Rectangle.inclusive_overlap_rectangle and now passes all the test cases without modifying the current .within workflow of the geostore

[jgravois]

sorry, but i've encountering the same High Sierra/PhantomJS problems that drove me to make the test harness updates below.

Esri/terraformer-arcgis-parser#52
Esri/terraformer-wkt-parser#34

i don't want to invest any more time than necessary here, but i'll figure out the bare minimum to get tests running locally soon.

thanks for the contribution (and your patience).

[seanmalter]

tested this further and might still have some issues with a larger set added to the geostore, need to investigate. Closing this for now.

[seanmalter]

Is anyone tracking this repo? I had a PR open but found there were issues with @jgravois suggested fix. I dug through the code and wasn't able to pin down the issue.

[vchan5]

I am also experiencing this issue. Is there a solution or workaround for now?

[jgravois]

Is anyone tracking this repo?

do you mean someone other than me? likely not.

see Esri/terraformer#268 for more info.