Code

Arnold Material Creation Improvements#58

Code

Merged

mistafunk merged 28 commits intomasterEsri/serlio:masterfrom arnold-material-deduplicationEsri/serlio:arnold-material-deduplicationCopy head branch name to clipboardJan 10, 2020

+341-201

Commits

Commits on Dec 11, 2019

• #40: factor out lookup of input mesh for shader creation

  mistafunk

  committed
  e7c17c1

Commits on Jan 6, 2020

• #40: make MaterialInfo comparable (key type for std::map)

  mistafunk

  committed
  7279c9f

• #40: implemented basic re-use of existing arnold material

  mistafunk

  committed
  55f0a01

• #40: const arnold material script helpers

  mistafunk

  committed
  a0ba1a1

• #40: store material metadata on shading node

  mistafunk

  committed
  7389676

• #40: factor out shading engine name handling and creation

  mistafunk

  committed
  58a0c3a

• #40: factor out finding named objects

  mistafunk

  committed
  ea1ee86

• #40: switch material cache to string value

  Show description for c9cb4b1
  mistafunk

  committed
  c9cb4b1

• #40: cleanup: logging, parentheses, assert

  mistafunk

  committed
  192f7f2

• #40: cleanup: deduplicate assignment of shading engine to faces

  mistafunk

  committed
  5c1044d

• #40: abstract away material caching mechanism

  mistafunk

  committed
  aed5e0e

Commits on Jan 9, 2020

• #40: review: remove redundant comparison operator templates

  mistafunk

  committed
  4b13591

• #40: review: tiny variable rename

  mistafunk

  committed
  28ea11f

Commits on Jan 10, 2020

• #40: review: return script output for synchronous mel execution

  mistafunk

  committed
  1f645ed

• #40: review: return actually created set name (shadingEngine)

  mistafunk

  committed
  d598197

• #40: review: capture shader name (potentially modified by maya)

  mistafunk

  committed
  ab4e85e

• #40: review: let maya make the shading engine and shader names unique

  mistafunk

  committed
  c0eaa5e

• #40: review: prefer const-ref and use consistent early-continue

  mistafunk

  committed
  4522fac

• #40: review: rename variables and comment for clarity

  mistafunk

  committed
  820fc11

• #40: review: ensure perfect forwarding

  mistafunk

  committed
  1f74bb8

• #40: review: header include cleanup (partial)

  mistafunk

  committed
  3d30c19

• #40: review: demoting material creation logging

  mistafunk

  committed
  c512805

• #40: review: disable MEL command echoing

  mistafunk

  committed
  20a4ed5

• #40: review 2: stricter check for stream element count

  mistafunk

  committed
  dc1da81

• #40: review 2: prefer return value over in-out variables

  mistafunk

  committed
  ed4057f

• #40: review 2: single definition of MEL variable name

  mistafunk

  committed
  2143c55

• #40: review 2: fix forward declaration

  mistafunk

  committed
  87ec29c

• #40: review 2: improve perfect forwarding in cache template

  mistafunk

  committed
  64e74fe