#40: review 2: improve perfect forwarding in cache template

Esri · Jan 10, 2020 · 64e74fe · 64e74fe
1 parent 87ec29c
commit 64e74fe
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/serlio/util/Utilities.h b/src/serlio/util/Utilities.h
@@ -248,12 +248,14 @@ std::basic_string<C> join(Container const& container, const std::basic_string<C>
 #	define MAYBE_UNUSED // [[maybe_unused]] would require /std:c++latest i.e. C++17
 #endif
 
-template <typename M, typename F, typename... ARGS>
-auto getCachedValue(M& cache, const typename M::key_type& key, F valueFunc, ARGS&&... valueFuncArgs) {
+template <typename M, typename K, typename F, typename... ARGS,
+          typename =
+                  typename std::enable_if_t<std::is_convertible<typename std::decay_t<K>, typename M::key_type>::value>>
+auto getCachedValue(M& cache, K&& key, F valueFunc, ARGS&&... valueFuncArgs) {
 	auto p = cache.find(key);
 	if (p == cache.end()) {
-		auto value = valueFunc(std::forward<ARGS&&...>(valueFuncArgs)...);
-		p = cache.emplace(key, value).first;
+		auto&& value = valueFunc(std::forward<ARGS>(valueFuncArgs)...);
+		p = cache.emplace(std::forward<K>(key), std::forward<decltype(value)>(value)).first;
 	}
 	return p->second;
-}
+}