Merge pull request #474 from andygup/3.3

v3.3

CHANGELOG.md

@@ -1,5 +1,17 @@
 # offline-editor-js - Changelog
 
+## Version 3.3.0 - June 12, 2016
+
+No breaking changes.
+
+**Enhancements**
+* Closes #473 - offline edits breaking when special characters such as "&" are used within attribute values.
+
+## Changed deprecation notice to Maintenance Mode notice - June 1, 2016
+
+Per several requests, this hopefully clarifies that the library is still being maintained and not being 
+removed.
+
 ## Deprecation details - May 23, 2016
 
 For details and comments on the deprecation refer to this [issue](https://github.com/Esri/offline-editor-js/issues/468).

dist/offline-edit-advanced-src.js

@@ -1,4 +1,4 @@
-/*! esri-offline-maps - v3.2.0 - 2016-05-12
+/*! esri-offline-maps - v3.3.0 - 2016-07-12
 *   Copyright (c) 2016 Environmental Systems Research Institute, Inc.
 *   Apache License*/
 // Configure offline/online detection
@@ -2033,15 +2033,15 @@ define([
                                 delete add.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        a = "&adds=" + JSON.stringify((adds));
+                        a = "&adds=" + encodeURIComponent(JSON.stringify(adds));
                     }
                     if(updates.length > 0) {
                         array.forEach(updates, function(update){
                             if(update.hasOwnProperty("infoTemplate")){ // if the update has an infoTemplate attached,
                                 delete update.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        u = "&updates=" + JSON.stringify(updates);
+                        u = "&updates=" + encodeURIComponent(JSON.stringify(updates));
                     }
                     if(deletes.length > 0) {
                         var id = deletes[0].attributes[this.DB_UID];

dist/offline-edit-basic-src.js

@@ -1,4 +1,4 @@
-/*! esri-offline-maps - v3.2.0 - 2016-05-12
+/*! esri-offline-maps - v3.3.0 - 2016-07-12
 *   Copyright (c) 2016 Environmental Systems Research Institute, Inc.
 *   Apache License*/
 // Configure offline/online detection
@@ -944,15 +944,15 @@ define([
                                 delete add.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        a = "&adds=" + JSON.stringify((adds));
+                        a = "&adds=" + encodeURIComponent(JSON.stringify(adds));
                     }
                     if(updates.length > 0) {
                         array.forEach(updates, function(update){
                             if(update.hasOwnProperty("infoTemplate")){ // if the update has an infoTemplate attached,
                                 delete update.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        u = "&updates=" + JSON.stringify(updates);
+                        u = "&updates=" + encodeURIComponent(JSON.stringify(updates));
                     }
                     if(deletes.length > 0) {
                         var id = deletes[0].attributes[this.DB_UID];

dist/offline-tiles-advanced-src.js

@@ -1,4 +1,4 @@
-/*! esri-offline-maps - v3.2.0 - 2016-05-12
+/*! esri-offline-maps - v3.3.0 - 2016-07-12
 *   Copyright (c) 2016 Environmental Systems Research Institute, Inc.
 *   Apache License*/
 define([

dist/offline-tiles-basic-src.js

@@ -1,4 +1,4 @@
-/*! esri-offline-maps - v3.2.0 - 2016-05-12
+/*! esri-offline-maps - v3.3.0 - 2016-07-12
 *   Copyright (c) 2016 Environmental Systems Research Institute, Inc.
 *   Apache License*/
 define([

dist/offline-tpk-src.js

@@ -1,4 +1,4 @@
-/*! esri-offline-maps - v3.2.0 - 2016-05-12
+/*! esri-offline-maps - v3.3.0 - 2016-07-12
 *   Copyright (c) 2016 Environmental Systems Research Institute, Inc.
 *   Apache License*/
 /**

lib/edit/OfflineEditAdvanced.js

@@ -2017,15 +2017,15 @@ define([
                                 delete add.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        a = "&adds=" + JSON.stringify((adds));
+                        a = "&adds=" + encodeURIComponent(JSON.stringify(adds));
                     }
                     if(updates.length > 0) {
                         array.forEach(updates, function(update){
                             if(update.hasOwnProperty("infoTemplate")){ // if the update has an infoTemplate attached,
                                 delete update.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        u = "&updates=" + JSON.stringify(updates);
+                        u = "&updates=" + encodeURIComponent(JSON.stringify(updates));
                     }
                     if(deletes.length > 0) {
                         var id = deletes[0].attributes[this.DB_UID];

lib/edit/OfflineEditBasic.js

@@ -928,15 +928,15 @@ define([
                                 delete add.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        a = "&adds=" + JSON.stringify((adds));
+                        a = "&adds=" + encodeURIComponent(JSON.stringify(adds));
                     }
                     if(updates.length > 0) {
                         array.forEach(updates, function(update){
                             if(update.hasOwnProperty("infoTemplate")){ // if the update has an infoTemplate attached,
                                 delete update.infoTemplate; // delete it to reduce payload size.
                             }
                         }, this);
-                        u = "&updates=" + JSON.stringify(updates);
+                        u = "&updates=" + encodeURIComponent(JSON.stringify(updates));
                     }
                     if(deletes.length > 0) {
                         var id = deletes[0].attributes[this.DB_UID];

package.json

@@ -1,6 +1,6 @@
 {
   "name": "esri-offline-maps",
-  "version": "3.2.0",
+  "version": "3.3.0",
   "description": "Lightweight set of libraries for working offline with map tiles and editing with ArcGIS feature services",
   "author": "Andy Gup <[email protected]> (http://blog.andygup.net)",
   "license": "Apache 2.0",

samples/appcache-features.html

@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html manifest="appcache-features.appcache">
+<!--<html manifest="appcache-features.appcache">-->
 <html>
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

samples/package.json

@@ -9,7 +9,7 @@
   "appHomePage": "appcache-tiles.html",
   "optimizedApiURL": "../samples/jsolib",
   "arcGISBaseURL": "http://js.arcgis.com/3.14",
-  "version": "3.2.0",
+  "version": "3.3.0",
   "private": true,
   "description": "manifest generator project",
   "repository": {