Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change export location #1802

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix: change export location #1802

merged 2 commits into from
Feb 12, 2025

Conversation

dbouwman
Copy link
Member

  1. Description:

Previous PR resulted in some exports not being "found" when running the stencil spec tests. This just changes their export location form /search/index.ts to /index.ts

Copying this build into the -ui monorepo resulted in the spec tests all running clean, so... I believe that's the verification we need

  1. Instructions for testing:

run tests.

  1. Closes Issues: # (if appropriate)

  2. na/ Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  3. used semantic commit messages

  4. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  5. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@dbouwman dbouwman merged commit cc19da5 into master Feb 12, 2025
5 checks passed
@dbouwman dbouwman deleted the b/12062-broken-export branch February 12, 2025 20:43
esri-dcdev-2 pushed a commit that referenced this pull request Feb 12, 2025
## @esri/hub-common [15.31.2](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-12)

### Bug Fixes

* change export location ([#1802](#1802)) ([cc19da5](cc19da5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants