Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sample: Style geometry types with symbols #1524

Merged
merged 10 commits into from
Sep 16, 2024

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Sep 11, 2024

Description

  • Implements StyleGeometryTypesWithSymbols samples across all platforms.
  • Removes RenderPictureMarkers and RenderSimpleMarkers designs.
  • Extends functionality of color converters to help with sample implementation.
    • For example, support conversion of a System.Drawing.Color.

Type of change

  • New sample implementation

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

this control is a picker not a combobox on this platform
Copy link
Collaborator

@duffh duffh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@williambohrmann3 williambohrmann3 merged commit a529c2a into main Sep 16, 2024
6 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/StyleGeometryTypesWithSymbols branch September 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants