Geometry Editor #1251

williambohrmann3 · 2023-06-02T20:25:04Z

Description

Add new sample: Create and edit geometries
Feature Create and edit geometries
Remove sample: Sketch on map
Remove Sketch on map resources from .Net.csproj and .NetFramework.csproj

Type of change

New sample implementation

Platforms tested on

Checklist

Self-review of changes
All changes work as expected on all affected platforms
There are no warnings related to changes
Code is commented and follows .NET conventions and standards
Codemaid and XAML styler extensions have been run on every changed file
No unrelated changes have been made to any other code or project files
Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

jnery-yy

Great job, @williambohrmann3! All samples are looking very polished.

I just reviewed the WPF bits but most of my suggestions probably apply to other platforms. Please feel free to apply only what you think is necessary. Like if samples team have a prescribed way of doing things, then go with consistency. I think most of my comments are for readability or making things concise.

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

src/WPF/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

duffh · 2023-06-06T09:08:58Z

Missing nuget package updates to 200.2

duffh · 2023-06-06T09:30:41Z

Slightly unintuitive UI when you can select the Freehand Tool but then Point and Multipoint change the tool back to Vertex Tool. Maybe disable these buttons while Freehand Tool is selected?

duffh · 2023-06-06T09:39:19Z

src/WinUI/ArcGIS.WinUI.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/readme.md

+
+## Additional information
+
+The sample opens with the ArcGIS Imagery basemap centered on the island of Inis Me�in (Aran Islands) in Ireland. Inis Me�in comprises a landscape of interlinked stone walls, roads, buildings, archaeological sites, and geological features, producing complex geometrical relationships.


The á character is not rendering properly in the sample viewer.

Maybe we change the text to Inishmaan unless you know of a workaround?

I think for this case just use a rather than á it's close enough for our purposes.

duffh · 2023-06-06T10:58:33Z

...IS.WinUI.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml

+    <UserControl.Resources>
+        <FontFamily x:Key="Calcite">/Resources/Fonts/calcite-ui-icons-24.ttf#calcite-ui-icons-24</FontFamily>
+    </UserControl.Resources>
+    <Grid>


UI looks a little cramped and maybe a little too large.

duffh · 2023-06-06T11:25:04Z

...UI/Maui.Samples/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml

+             xmlns:esriUI="clr-namespace:Esri.ArcGISRuntime.Maui;assembly=Esri.ArcGISRuntime.Maui">
+    <Grid>
+        <esriUI:MapView x:Name="MyMapView" GeoViewTapped="MyMapView_GeoViewTapped" />
+        <Grid Margin="5,5,5,5"


UI doesn't fit on the screen on mobile in horizontal orientation.

duffh

Looks good, just a few comments just now.

jnery-yy

Thanks for the update, just few more questions; but otherwise, I think it's much closer to done!

src/WPF/WPF.Viewer/Converters/BoolNegationConverter.cs

jnery-yy · 2023-06-09T20:47:44Z

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

+
+            // Account for case when vertex tool is selected and geometry editor is started with a polyline or polygon geometry type.
+            // Ensure point and multipoint buttons are only enabled when the selected tool is a vertex tool.
+            PointButton.IsEnabled = MultipointButton.IsEnabled = !_geometryEditor.IsStarted && tool is VertexTool;


Is this needed when DisableOtherGeometryButtons(..) was called by start polyline/polygon button click?

I don't believe this is technically necessary. But is it worth adding a geometry editor type conditional check around this?

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

jnery-yy · 2023-06-09T23:33:21Z

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

+            GeometryType geometryType = _selectedGraphic.Geometry.GeometryType;
+            if (geometryType == GeometryType.Point || geometryType == GeometryType.Multipoint)
+            {
+                ToolComboBox.SelectedIndex = 0;


I think we want VertexTool to always be the default.
Allowing users to change it to Freehand when Polyline/Polygon seem enough. Which you're doing by handling the ComboBox.SelectionChanged event

If user has freehand tool enabled, selects a polyline/polygon, no need to change the tool to vertex tool. But if they have freehand tool enabled, select a point/multipoint, it is necessary to change the tool to a vertex tool.

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

duffh · 2023-06-15T15:16:11Z

...Maui.Samples/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs

+            _polygonSymbol = new SimpleFillSymbol(SimpleFillSymbolStyle.Solid, Color.FromArgb(70, 255, 0, 0), polygonLineSymbol);
+
+            // Create geometry objects from JSON formatted strings.
+            var houseCoordinates = (MapPoint)Geometry.FromJson


I'd pull these json strings out of the method as constant strings, it just tidies up readability. We do this in other samples.

duffh

Looking better!

jnery-yy

LGTM, thanks 👍

williambohrmann3 · 2023-06-15T21:38:05Z

Checks are failing because of lowercase screenshot name for MAUI.

duffh · 2023-06-16T15:58:30Z

Checks are failing because of lowercase screenshot name for MAUI.

Looks like the README check is failing as the metadata is inconsistent, the difference is that I think it is expecting a .png image but we are using a .jpg for our screenshot. I'll take a look at the check.

duffh · 2023-06-16T16:07:31Z

The checks are failing because the screenshot should be a .jpg file not a .png. If you update this both checks should pass.

williambohrmann3 and others added 10 commits May 23, 2023 17:34

samplegen

78e2d20

WPF implementation

85b035b

WinUI implementation

84eb929

MAUI implementation

ecbb83d

samplesync

9459aa1

MAUI - remove extra border

0996442

MAUI XAML styled

314aac6

Remove SketchOnMap

8144121

remove SketchOnMap from viewer readme's

7e05796

Feature sample

08d7214

williambohrmann3 self-assigned this Jun 2, 2023

.csproj remove SketchOnMap resources

54140e5

williambohrmann3 requested review from jnery-yy and duffh June 2, 2023 20:53

jnery-yy suggested changes Jun 2, 2023

View reviewed changes

duffh reviewed Jun 6, 2023

View reviewed changes

duffh requested changes Jun 6, 2023

View reviewed changes

williambohrmann3 added 5 commits June 9, 2023 10:24

package reference versions

82ebfe6

feedback implemented - MAUI

2c30b72

feedback implemented - WPF

2900053

feedback implemented - WinUI

f7811ea

accent character removal

78fade2

williambohrmann3 requested review from duffh and jnery-yy June 9, 2023 17:55

NETFramework package references

47c6999

jnery-yy suggested changes Jun 9, 2023

View reviewed changes

jnery-yy suggested changes Jun 10, 2023

View reviewed changes

...F/WPF.Viewer/Samples/GraphicsOverlay/CreateAndEditGeometries/CreateAndEditGeometries.xaml.cs Show resolved Hide resolved

duffh reviewed Jun 15, 2023

View reviewed changes

duffh requested changes Jun 15, 2023

View reviewed changes

some final touches

789f1aa

williambohrmann3 requested review from jnery-yy and duffh June 15, 2023 21:06

jnery-yy approved these changes Jun 15, 2023

View reviewed changes

williambohrmann3 added 2 commits June 15, 2023 14:23

readme Inis Meain

129bdb6

Inis Meain MAUI char fix

4ee4dd4

png -> jpg

3a434c9

duffh approved these changes Jun 20, 2023

View reviewed changes

williambohrmann3 merged commit 4f8a680 into v.next Jun 20, 2023

williambohrmann3 deleted the wbohr/GeometryEditor branch June 20, 2023 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geometry Editor #1251

Geometry Editor #1251

williambohrmann3 commented Jun 2, 2023 •

edited

Loading

jnery-yy left a comment

duffh commented Jun 6, 2023

duffh commented Jun 6, 2023

duffh Jun 6, 2023

williambohrmann3 Jun 8, 2023

duffh Jun 9, 2023

duffh Jun 6, 2023

duffh Jun 6, 2023

duffh left a comment

jnery-yy left a comment

jnery-yy Jun 9, 2023

williambohrmann3 Jun 15, 2023

jnery-yy Jun 9, 2023

williambohrmann3 Jun 15, 2023

duffh Jun 15, 2023

duffh left a comment

jnery-yy left a comment

williambohrmann3 commented Jun 15, 2023

duffh commented Jun 16, 2023

duffh commented Jun 16, 2023


		## Additional information

		The sample opens with the ArcGIS Imagery basemap centered on the island of Inis Me�in (Aran Islands) in Ireland. Inis Me�in comprises a landscape of interlinked stone walls, roads, buildings, archaeological sites, and geological features, producing complex geometrical relationships.

Geometry Editor #1251

Geometry Editor #1251

Conversation

williambohrmann3 commented Jun 2, 2023 • edited Loading

Description

Type of change

Platforms tested on

Checklist

jnery-yy left a comment

Choose a reason for hiding this comment

duffh commented Jun 6, 2023

duffh commented Jun 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duffh left a comment

Choose a reason for hiding this comment

jnery-yy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duffh left a comment

Choose a reason for hiding this comment

jnery-yy left a comment

Choose a reason for hiding this comment

williambohrmann3 commented Jun 15, 2023

duffh commented Jun 16, 2023

duffh commented Jun 16, 2023

williambohrmann3 commented Jun 2, 2023 •

edited

Loading