Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm install subfolders #174

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

esride-nik
Copy link
Contributor

Added a script in root to scan widget folders for package.json files and npm i all of those. For now, this only concerns react-data-grid, but other widgets might incorporate 3rd party packaged in the future. This is a great way to avoid manually looking for package.jsons in all subfolders.

@qlqllu
Copy link
Collaborator

qlqllu commented Jan 24, 2024

Hi @esride-nik Thanks for your PR! We have added this feature in the latest code, so it'll be available in the next release. Let's keep this PR open until next release to see whether we still need to merge it.

@esride-nik
Copy link
Contributor Author

Hey @qlqllu, next release is here. What did you mean by "added this feature in the latest code"? Is there a feature in the 1.14 release that does this? If so, I can't find anything about it in the docs.. can you please provide a link?

@qlqllu
Copy link
Collaborator

qlqllu commented Mar 29, 2024

@esride-nik
Copy link
Contributor Author

Hi @qlqllu, I just stumbled upon this during my latest re-install: => "This automatic install will only happen for widgets that are in the your-extensions folder." That's exactly the problem. The "exb-web-extension-repo" is a brilliant feature for any developer working in several projects at the same time. I haven't been using the "your-extensions" folder for years..
It would be great to see ExB natively solve the issue of installing all dependencies for all repos clones into the "client" folder. In the meantime, "npm-install-subfolders" does the job on repository root level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants