fix: simulate restarting the espresso-dev-node (#557) #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: simulate restarting the espresso-dev-node The node currently does not support restarting from previously saved state and doing so leads to undefined behaviour. * shutdown dev-node at the end of E2E test * reconnect network before resuming dev node (cherry picked from commit 479288d)
sveitser
requested review from
ImJeremyHe,
alysiahuggins,
zacshowa,
Sneh1999 and
jbearer
as code owners
|
Espresso CI has passed and remaining CI failures seem unrelated to this PR. Will open another PR to fix them. reference rust-lang/rustup#2417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic backport on PR #557 failed.
The node currently does not support restarting from previously saved state and doing so leads to undefined behaviour.
shutdown dev-node at the end of E2E test
reconnect network before resuming dev node
(cherry picked from commit 479288d)