Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: benchmark on bls signature schemes #346

Merged
merged 7 commits into from
Aug 1, 2023
Merged

feat: benchmark on bls signature schemes #346

merged 7 commits into from
Aug 1, 2023

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Jul 20, 2023

Description

Benchmark on bls signature schemes over Bn254 and BLS12-381.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also benchmark signature aggregation?

@mrain
Copy link
Contributor Author

mrain commented Jul 21, 2023

shouldn't we also benchmark signature aggregation?

@alxiong You mean aggregate_verify right? I have a question about how many keys shall we include here.

@mrain mrain requested a review from alxiong July 25, 2023 20:23
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrain mrain merged commit 903d32a into main Aug 1, 2023
3 checks passed
@mrain mrain deleted the sig-benches branch August 1, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants