Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling, Rate link update, busy indicator when generating files #2830

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BillKrat
Copy link
Contributor

@BillKrat BillKrat commented Feb 4, 2025

Busy.mp4
  • Provided a visual indication that generating files will require patience (video above)
  • Added error handling when generating files - errors display on status page (image below)
  • Provided proper link for Rate

ErrorHandling

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 4, 2025

@BillKrat Waiting indicator - not so fond of the graphic - I think you misunderstood, sorry if I was unclear - I just want a spinning button, like on "Getting database objects".

And for the error, I dont think I mentioned GenerateFiles, the error I for example got was using an invalid connection, causing a crash.

And more info about any errors is always helpful, but maybe the error you show is a fabricated one?

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 4, 2025

Example of "hard" connection error (I am fine with sharing full details here, I just want to avoid the hang)

image

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 4, 2025

Did you rebase on latest master?

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 4, 2025

The hang dialog only appears when you want to exit VS btw

@BillKrat
Copy link
Contributor Author

BillKrat commented Feb 4, 2025

@ErikEJ Let's go ahead and kill this PR - I'll regroup and start over. If I understand you correctly I can duplicate the issue by simply providing an invalid connection string?

  • I can't recall if I rebased on latest master before starting, I'll be sure to do so this time.
  • I wasn't real sure where the error was occurring so I assumed it was while generating files (yes I threw that error manually)
  • As to status/progress, the best we're going to get is a message in statusbar as it does OR somewhere on the screen, perhaps the "message" on the screen without the graphic?.

Getting WPF to perform any animation, while it is working, is an age old issue . It is not really something you can "add" as an afterthought easily - the framework has to be designed for it as suggested by this article Threads in WPF. If you google "WPF Spinner freezes while working" you'll see many issues, no solutions; the ones presented don't work and the controls that use to handle this have been abandoned.

With Rick Strahl's status bar we at least get a change to see something "before" the async processes kick off and the UI thread freezes.

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 4, 2025

Fair about the spinner - fine to restart this

@BillKrat
Copy link
Contributor Author

BillKrat commented Feb 4, 2025

Note: I hadn't programmed in WPF for nearly 6-7 years. My focus has been Angular, C#, and WebApi (for work and hobbies). It seems it has a chance to make a good comeback since it is part of the .NET 8 Core framework. So I wouldn't say I'm an expert, I've just not seen anything to suggest much has changed in this area - I've tried many different things to no avail....

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 4, 2025

The VS status bar has a progress bar that is semi animated... but let's leave it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants