-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling, Rate link update, busy indicator when generating files #2830
base: master
Are you sure you want to change the base?
Conversation
…rovide visual indication that patience may be required
@BillKrat Waiting indicator - not so fond of the graphic - I think you misunderstood, sorry if I was unclear - I just want a spinning button, like on "Getting database objects". And for the error, I dont think I mentioned GenerateFiles, the error I for example got was using an invalid connection, causing a crash. And more info about any errors is always helpful, but maybe the error you show is a fabricated one? |
Did you rebase on latest master? |
The hang dialog only appears when you want to exit VS btw |
@ErikEJ Let's go ahead and kill this PR - I'll regroup and start over. If I understand you correctly I can duplicate the issue by simply providing an invalid connection string?
Getting WPF to perform any animation, while it is working, is an age old issue . It is not really something you can "add" as an afterthought easily - the framework has to be designed for it as suggested by this article Threads in WPF. If you google "WPF Spinner freezes while working" you'll see many issues, no solutions; the ones presented don't work and the controls that use to handle this have been abandoned. With Rick Strahl's status bar we at least get a change to see something "before" the async processes kick off and the UI thread freezes. |
Fair about the spinner - fine to restart this |
Note: I hadn't programmed in WPF for nearly 6-7 years. My focus has been Angular, C#, and WebApi (for work and hobbies). It seems it has a chance to make a good comeback since it is part of the .NET 8 Core framework. So I wouldn't say I'm an expert, I've just not seen anything to suggest much has changed in this area - I've tried many different things to no avail.... |
The VS status bar has a progress bar that is semi animated... but let's leave it for now |
Busy.mp4