Fix pdk validate github workflow #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-larsson
changed the title
|
Oh this detail didn't catch my attention. Good that you find and fixed it. |
Phil-Friderici
approved these changes
Feb 19, 2024
|
Was a big surprise when it took ages for pdk validate to finish. Had to investigate it . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops. Didn't realise that there were different actions used for validate and test. Before this PR pdk test was executed instead of pdk validate for the validate action.
Made a fork of puppets-epic-show-theatre/action-pdk-validate as well. Branch
buildtoolscontains gcc and make to ensure gemwebmock(or more precisely a dependency of) can be installed.