Skip to content

Commit

Permalink
[bazel] Allow SupportTests to be built remotely and cached (llvm#121375)
Browse files Browse the repository at this point in the history
`SupportTests` fails in the bazel macOS sandbox, because
`FileSystemTest.permissions` expects to be able to modify file
permissions on some otherwise protected files.

Previously this test was marked `local` in bazel, which has
additional undesirable effects such as skipping remote build and cache.

Tighten the bazel tags to just `no-sandbox`.  Note in particular, that
this allows the test to build, execute, and cache remotely (if
configured).

Testing:
- Verified this test fails (as expected) on macOS with no tags, and
  passes with `no-sandbox`.
- Verified this test passes when executed remotely (using an Engflow RBE
  setup) with `no-sandbox`.
  • Loading branch information
anguslees authored Jan 2, 2025
1 parent 5de7af4 commit bca92b1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ cc_test(
],
linkstatic = 1,
tags = [
"local", # Not compatible with the sandbox on MacOS
"no-sandbox", # FileSystemTest.permissions not compatible with the sandbox on MacOS
],
deps = [
"//llvm:AllTargetsCodeGens",
Expand Down

0 comments on commit bca92b1

Please sign in to comment.