Skip to content

Commit

Permalink
Revert "[Clang-REPL] Fix crash during __run_exit_handlers with dyna…
Browse files Browse the repository at this point in the history
…mic libraries. (llvm#117475)"

This reverts commit 30ad53b as it breaks
systems that don't have a systemwide libc++ or libstdc++ installed. It should
be rewritten to not invoke the system linker. In the meanwhile, reverting
to unblock the bots.
  • Loading branch information
dcci committed Dec 14, 2024
1 parent 9ddcaed commit 61ab36a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 23 deletions.
4 changes: 1 addition & 3 deletions clang/lib/Interpreter/Interpreter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -719,9 +719,7 @@ llvm::Error Interpreter::LoadDynamicLibrary(const char *name) {

if (auto DLSG = llvm::orc::DynamicLibrarySearchGenerator::Load(
name, DL.getGlobalPrefix()))
// FIXME: Eventually we should put each library in its own JITDylib and
// turn off process symbols by default.
EE->getProcessSymbolsJITDylib()->addGenerator(std::move(*DLSG));
EE->getMainJITDylib().addGenerator(std::move(*DLSG));
else
return DLSG.takeError();

Expand Down
20 changes: 0 additions & 20 deletions clang/test/Interpreter/crash.cpp

This file was deleted.

0 comments on commit 61ab36a

Please sign in to comment.