-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ered an application with its own supervision tree #41
base: main
Are you sure you want to change the base?
Conversation
a689874
to
f84f0e9
Compare
The command handling code is moved from ered to ered_cluster. The ered module becomes just an API module without a process of its own. This eliminates some duplicated structures and copying between processes. Change ered_client_sup into to simple_one_for_one supervisor. No API changes.
Ered becomes an application with its own supervision tree. In the API, connect_cluster/2 replaces start_link/2 and close/1 replaces stop/1. The processes are added to ered's own supervision tree. An ered instance monitors the caller and closes down if the owner dies, much like the controlling process concept in gen_tcp and ssl.
The process traps exits so terminate/1 will run even if the process crashes.
Make the messages sent by a standalone ered_client match those sent by a cluster client for each client, i.e. a map with the keys msg_type, reason, client_id, addr and the optional fields cluster_id and master.
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]> Co-authored-by: Björn Svensson <[email protected]>
I have a quick question on line: Line 236 in 4374c5e
is it by design that sth like I built a little plugin using ered as an application as in this PR. Works great so far! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a big change but I haven't found anything more to comment on after a couple of walkthroughs.
It's a good sign that the tests are more or less unchanged.
This PR contains some separate commits. It might be better to review them one by one.
Merge ered and ered_cluster processes
The command handling code is moved from ered to ered_cluster. The ered
module becomes just an API module without a process of its own. This
eliminates some duplicated structures and copying between processes.
Change ered_client_sup into to simple_one_for_one supervisor.
App and supervision tree
Ered becomes an application with its own supervision tree.
In the API, connect_cluster/2 replaces start_link/2 and close/1 replaces
stop/1. The processes are added to ered's own supervision tree. An ered
instance monitors the caller and closes down if the owner dies, much like
the controlling process concept in gen_tcp and ssl.
Add info message 'cluster_stopped' sent in ered_cluster:terminate/1
The process traps exits so terminate/1 will run even if the process
crashes.
Unify info messages from ered_client and ered_cluster
Make the messages sent by a standalone ered_client match those sent
by a cluster client for each client, i.e. a map with the keys
msg_type, reason, client_id, addr and the optional fields
cluster_id and master.