Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make locks dynamic based on TTL of lock table #587

Merged
merged 14 commits into from
Oct 20, 2023
Merged

Make locks dynamic based on TTL of lock table #587

merged 14 commits into from
Oct 20, 2023

Conversation

SajidRiaz138
Copy link
Contributor

@SajidRiaz138 SajidRiaz138 commented Oct 12, 2023 •
edited by masokol
Loading

Closes #543

sajid riaz added 3 commits October 11, 2023 16:25
Make lock refresh + failure cache configurable#543
0c017cd 
Make lock refresh and lock failure cache configurable,
 the defaults should be as they're today, but preferably
 dynamic based on the TTL of ecchronos.lock table.

Today these values are hardcoded (assuming TTL of 10 minutes):

Lock refresh 1 min (retry 9 times)
Lock failure cache, 30 secs
Make lock refresh + failure cache configurable#543
f1e8d09 
Make lock refresh and lock failure cache configurable,
 the defaults should be as they're today, but preferably
 dynamic based on the TTL of ecchronos.lock table.

Today these values are hardcoded (assuming TTL of 10 minutes):

Lock refresh 1 min (retry 9 times)
Lock failure cache, 30 secs
Make lock refresh + failure cache configurable#543
35ebee4 
Make lock refresh and lock failure cache configurable,
 the defaults should be as they're today, but preferably
 dynamic based on the TTL of ecchronos.lock table.

Today these values are hardcoded (assuming TTL of 10 minutes):

Lock refresh 1 min (retry 9 times)
Lock failure cache, 30 secs
masokol
masokol reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@masokol masokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few first comments.

application/src/main/resources/ecc.yml Outdated Show resolved Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java Show resolved Hide resolved
...ation/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/ECChronosInternals.java Outdated Show resolved Hide resolved
...om/ericsson/bss/cassandra/ecchronos/application/config/lockfactory/CasLockFactoryConfig.java Show resolved Hide resolved
...om/ericsson/bss/cassandra/ecchronos/application/config/lockfactory/CasLockFactoryConfig.java Outdated Show resolved Hide resolved
Make lock refresh and lock failure cache configurable Ericsson#543
b6490e4 
Make lock refresh and lock failure cache configurable,
the defaults should be as they're today. Now values
would be picked from ecc.yml

Today these values are hardcoded (assuming TTL of 10 minutes):

Lock refresh 1 min (retry 9 times)
Lock failure cache, 30 secs
@SajidRiaz138 SajidRiaz138 marked this pull request as ready for review October 13, 2023 16:53
sajid riaz added 2 commits October 17, 2023 11:18
Make lock refresh and lock failure cache configurable Ericsson#543
7ab2286 
Make lock refresh and lock failure cache configurable,
the defaults should be as they're today. Now values
would be picked from ecc.yml
Make lock refresh and lock failure cache configurable Ericsson#543
ff20cc8 
Make lock refresh and lock failure cache configurable,
the defaults should be as they're today. Now values
would be picked from ecc.yml
masokol
masokol requested changes Oct 17, 2023
View reviewed changes
...om/ericsson/bss/cassandra/ecchronos/application/config/lockfactory/CasLockFactoryConfig.java Outdated Show resolved Hide resolved
application/src/main/resources/ecc.yml Outdated Show resolved Hide resolved
application/src/main/resources/ecc.yml Outdated Show resolved Hide resolved
...t/java/com/ericsson/bss/cassandra/ecchronos/application/config/TestCasLockFactoryConfig.java Outdated Show resolved Hide resolved
...t/java/com/ericsson/bss/cassandra/ecchronos/application/config/TestCasLockFactoryConfig.java Outdated Show resolved Hide resolved
...t/java/com/ericsson/bss/cassandra/ecchronos/application/config/TestCasLockFactoryConfig.java Outdated Show resolved Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java Outdated Show resolved Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java Outdated Show resolved Hide resolved
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/core/utils/CASLockFactoryCacheContext.java Outdated Show resolved Hide resolved
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/core/utils/CASLockFactoryCacheContext.java Outdated Show resolved Hide resolved
Make lock refresh and lock failure cache configurable Ericsson#543
f8caa6d 
Make lock refresh and lock failure cache configurable,
the defaults should be as they're today. Now values
would be picked from ecc.yml
@SajidRiaz138 SajidRiaz138 requested a review from masokol October 17, 2023 12:41
masokol
masokol reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@masokol masokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an entry in CHANGES.md for this PR and fix the title of the PR. Otherwise LGTM

@SajidRiaz138 SajidRiaz138 changed the title Lockcache dynamic configurations Make lock refresh + failure cache configurable #543 Oct 18, 2023
Make lock refresh + failure cache configurable Ericsson#543
6f43074 
Make lock refresh and lock failure cache configurable,
the defaults should be as they're today. Now values
would be picked from ecc.yml
@SajidRiaz138 SajidRiaz138 changed the title Make lock refresh + failure cache configurable #543 Make lock refresh + failure cache configurable #543 Oct 18, 2023
@SajidRiaz138 SajidRiaz138 requested a review from masokol October 18, 2023 12:30
Make lock refresh + failure cache configurable Ericsson#543
d997f4f 
Make lock failure cache configurable,
the defaults should be as they're today.
Now failure cache expiry time value would
be picked from ecc.yml.

Lock refresh is dynamic based on the TTL
of ecchronos.lock table
Dynamic lock Refresh and configurable failure Cache Ericsson#543
a7494c3 
Make expiry time of lock failure cache configurable,
the defaults should be as they're today.
Now failure cache expiry time value would
be picked from ecc.yml.

Lock refresh is dynamic based on the TTL
of ecchronos.lock table
@masokol masokol changed the title Make lock refresh + failure cache configurable #543 Make locks dynamic based on ttl of lock table Oct 19, 2023
@masokol masokol changed the title Make locks dynamic based on ttl of lock table Make locks dynamic based on TTL of lock table Oct 19, 2023
@SajidRiaz138 SajidRiaz138 requested a review from masokol October 19, 2023 14:01
@SajidRiaz138 SajidRiaz138 requested a review from masokol October 20, 2023 08:25
@masokol masokol merged commit a4d0744 into Ericsson:master Oct 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masokol masokol masokol approved these changes

@tommystendahl tommystendahl Awaiting requested review from tommystendahl

@jwaeab jwaeab Awaiting requested review from jwaeab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make lock refresh + failure cache configurable
2 participants
@SajidRiaz138 @masokol