fixing malparsed windows paths #4374
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-h38
reviewed
Oct 31, 2024
| @@ -1163,7 +1163,7 @@ def extend_compilation_database_entries(compilation_database): | |||
| source_files = [] | |||
| source_dir = entry['directory'] | |||
|
|
|||
| options = shlex.split(entry['command']) | |||
| options = shlex.split(entry['command'], posix=(os.name=='posix')) | |||
There was a problem hiding this comment.
The posix= parameter is designed to manage nuances between different Unix shells, so it's very mysterious how this helps with Windows and why?!
I realize this is still just a draft, but some... draft comments and a commit message draft would not hurt.
Generally speaking, shlex is NOT meant to help prepare Windows commands ("outputs"). According to its documentation, it's meant as a convenience to help parsing inputs to the program, like a simple configuration file or some parameters.
https://docs.python.org/3/library/shlex.html
Longer example of shlex abuse and Windows compatibility story in zephyrproject-rtos/west@94f8a04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4277