Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] Add support for sarif export in parser cmd #4327

Merged

Conversation

tgagneret-embedded
Copy link
Contributor

@tgagneret-embedded tgagneret-embedded commented Aug 26, 2024

Hello,

This PR allows to run CodeChecker parse -e sarif ./results -o sarif.json.

This PR only uses the convert function already present in Sarif Parser (https://github.com/Ericsson/codechecker/blob/master/tools/report-converter/codechecker_report_converter/report/parser/sarif.py#L297) and exposes it to the parser cmd.

This would close #4036 I think (I did not test the output on Github)

@tgagneret-embedded
Copy link
Contributor Author

Using https://sarifweb.azurewebsites.net/Validation it seems that the SARIF output file have some issues that need to be fixed for Github integration.

Do you think another PR should be created to support Github integration ?

@tgagneret-embedded tgagneret-embedded force-pushed the feature/sarif_export_support_parser branch from 54a5582 to 949c689 Compare August 28, 2024 07:59
@tgagneret-embedded
Copy link
Contributor Author

Linting issue are fixed. CI can run again.

@tgagneret-embedded
Copy link
Contributor Author

@bruntib @vodorok ?

@tgagneret-embedded
Copy link
Contributor Author

@bruntib @vodorok Do you plan to merge this PR ?
Thanks

@dkrupp dkrupp added this to the release 6.25.0 milestone Jan 24, 2025
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. sorry for the long review cycle.

@dkrupp dkrupp merged commit 8d85443 into Ericsson:master Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support exporting Static Analysis Results Interchange Format (SARIF)
2 participants