[cmd] Add support for sarif export in parser cmd #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using https://sarifweb.azurewebsites.net/Validation it seems that the SARIF output file have some issues that need to be fixed for Github integration. Do you think another PR should be created to support Github integration ? |
tgagneret-embedded
force-pushed
the
feature/sarif_export_support_parser
branch
from
54a5582
to
949c689
Compare
|
Linting issue are fixed. CI can run again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR allows to run
CodeChecker parse -e sarif ./results -o sarif.json.This PR only uses the
convertfunction already present in Sarif Parser (https://github.com/Ericsson/codechecker/blob/master/tools/report-converter/codechecker_report_converter/report/parser/sarif.py#L297) and exposes it to the parser cmd.This would close #4036 I think (I did not test the output on Github)