-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Oauth of Github, Google and Microsoft #4298
Open
feyruzb
wants to merge
95
commits into
Ericsson:master
Choose a base branch
from
feyruzb:branch-2-backup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feyruzb
force-pushed
the
branch-2-backup
branch
2 times, most recently
from
July 25, 2024 11:05
5ce7f18
to
68eaf7b
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
2 times, most recently
from
July 30, 2024 11:02
de2e213
to
d3f6b29
Compare
vodorok
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my remarks.
I have some additional comments apart from the direct in code messages:
- My major concern with the implementation is that the oauth related API and its implementation is not generalized enough. The configuration is good enough for the time being.
- I am not sure if we are allowed to use the Git Hub logo in our repo.
- Please invite @cservakt to review the JS and VueJS parts.
I did not do a thorough review of the oauth flow in authentication.py
after you addressed the above issues I will do another round concentrating on that.
Thanks for the hard work!
feyruzb
force-pushed
the
branch-2-backup
branch
10 times, most recently
from
July 31, 2024 14:41
12c68e7
to
f064c2b
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
3 times, most recently
from
July 31, 2024 16:05
b4d5a0a
to
d3847d6
Compare
…s, commented lines
feyruzb
force-pushed
the
branch-2-backup
branch
3 times, most recently
from
December 9, 2024 14:05
7149ef4
to
1287f13
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
December 9, 2024 14:10
1287f13
to
ad5beec
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
December 9, 2024 15:12
545caa6
to
e3d6d7a
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
5 times, most recently
from
January 8, 2025 15:22
a197b51
to
22f46fb
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 8, 2025 15:27
22f46fb
to
4f083b4
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 9, 2025 14:27
c610497
to
1df88ff
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 9, 2025 15:00
bbd0a80
to
0b9f8f9
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 9, 2025 15:35
d74bf7d
to
15d710f
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 9, 2025 16:53
56c1ad7
to
9630841
Compare
…y email for GitHub
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 9, 2025 16:55
9630841
to
4393e55
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
2 times, most recently
from
January 15, 2025 15:59
06d2ed8
to
c2d4ba5
Compare
…the token fetching process
feyruzb
force-pushed
the
branch-2-backup
branch
from
January 15, 2025 16:04
c2d4ba5
to
e18d6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4160
The right way it should look after logging in
new added button to log in with github
Changes: