chore(config): Apply "no alpha checker in production profiles" invariant from label-tool
#4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riant from `label-tool`
whisperity
added
clang sa 🐉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.b., while the
label-tool, after having developed the changes of #4275, supports an invariant "no (Clang SA)alpha.(anddebug.) checkers inprofile:<any production profile>", #4291 did not contain the automatic fixes (removals from profiles) as emitted by thelabel-toolon purpose.Several
alpha.checkers are currently categorised selectively into[profile:extreme]or[profile:sensitive, profile:extreme](but no longer[profile:default, profile:sensitive, profile:extreme]since #4284!) which looks like an educated decision, one which would end up being violated by auto-applying the aforementioned invariant.Thus, I created this separate patch where we can discuss the way forward. Perhaps it is time to re-evaluate the list of
alpha.checkers, apply the invariant (remove them from all profiles which are "production-grade") and assign them into a new profile?