Merge pull request iovisor#265 from iovisor/yhs_dev

handle return value in kretprobe handler for tcpv4connect
ErickReyesR · Oct 12, 2015 · d8bf3e8 · d8bf3e8
2 parents 99dced7 + 366eb2e
commit d8bf3e8
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/tools/tcpv4connect b/tools/tcpv4connect
@@ -61,6 +61,13 @@ int kretprobe__tcp_v4_connect(struct pt_regs *ctx)
 		return 0;	// missed entry
 	}
 
+	if (ret != 0) {
+		// failed to send SYNC packet, socket __sk_common.{skc_rcv_saddr, ...}
+		// may not be populated properly.
+		currsock.delete(&pid);
+		return 0;
+	}
+
 	// pull in details
 	struct sock *skp = *skpp;
 	u32 saddr = 0, daddr = 0;