-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle assistant messages with 'tool_calls' #824
Conversation
Handle assistant messages with 'tool_calls' when used in chat_template
Code Metrics Report=============================================================================== Language Files Lines Code Comments Blanks =============================================================================== C Header 2 35 28 0 7 Dockerfile 1 41 22 10 9 Happy 1 442 369 0 73 JSON 12 105 104 0 1 Python 53 2274 1949 63 262 Shell 1 57 22 18 17 TOML 18 581 518 2 61 YAML 2 21 19 2 0 ------------------------------------------------------------------------------- Jupyter Notebooks 4 0 0 0 0 |- Markdown 2 77 32 31 14 |- Python 2 196 169 1 26 (Total) 273 201 32 40 ------------------------------------------------------------------------------- Markdown 40 3009 0 2286 723 |- BASH 6 101 98 0 3 |- JSON 1 12 12 0 0 |- Python 6 114 102 0 12 |- Rust 10 361 306 0 55 |- TOML 2 75 63 0 12 (Total) 3672 581 2286 805 ------------------------------------------------------------------------------- Rust 278 83174 74643 1743 6788 |- Markdown 134 1413 25 1285 103 (Total) 84587 74668 3028 6891 =============================================================================== Total 413 89739 77674 4124 7941 =============================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jeadie! Thanks for the PR. I think this looks good, but I was wondering if you could also please update the new Rust API (specifically, the tools
and tools_llama_8b
examples)? Perhaps you could create a method to add a tool call message?
Please let me know!
Friendly ping @Jeadie |
Will do today |
Add better methods for using tools in and update examples
I don't seem to have visibility into the failing check: https://github.com/EricLBuehler/mistral.rs/actions/runs/11357273044/job/31589861979?pr=824 |
@Jeadie I reran the check and it passed. Please let me know when this is ready for review! |
This is ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@Jeadie I noticed there are some outstanding merge conflicts, could you please resolve those? Thanks. |
@EricLBuehler Updated, thanks. |
Thank you! |
Changes
BasicProcessor
to usetemplate_action() -> MessagesAction::Keep
(instead ofMessagesAction::FlattenOnlyText
) .Fixes