Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lossy bidirectional links with length based efficiency #2

Closed
wants to merge 3 commits into from

Conversation

Eric-Nitschke
Copy link
Owner

Changes

  • modify the implementation of lossy bidirectional links based on the discussion in PR #1192
  • add an implementation for length based efficiency calculations based on the discussion in PR #1192

davide-f and others added 3 commits December 22, 2024 11:10
Major changes:
- Fix bidirectional lossy links by splitting the into to links in _helpers.py
- Add length based efficiency calculations in _helpers.py
Bug fixes:
- modify the override component location provided in the Snakefile to work with the "copy-minimal" shadow directory on Windows
- fix the identification of all forward links in scripts/solve_network.py
Eric-Nitschke pushed a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants