Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Faraday warning about basic_auth deprecation #1

Open
wants to merge 1 commit into
base: fix-deprecation
Choose a base branch
from

Conversation

vnorguet
Copy link

@vnorguet vnorguet commented Oct 6, 2021

Context

Faraday has deprecated Faraday::Connection#basic_auth and show a warning message when running the code

Warning message

WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in vers`ion 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

What does this PR do

Fix warning message by updating related code to the latest version

@vnorguet vnorguet marked this pull request as draft October 6, 2021 12:24
@vnorguet vnorguet marked this pull request as ready for review October 20, 2021 09:17
@benlings
Copy link

@ErebusBat Can this be merged? I'd rather not make another fork to combine both yours and @vnorguet 's...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants