Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: make sql_from_csv externally callable #205

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

pruoff
Copy link
Contributor

@pruoff pruoff commented Feb 9, 2024

The util function sql_from_csv is very useful for external use but failed when called externally for its local reference to sql_from_csv_input. The reference is made global.

@cdiniz cdiniz added the safe to test Label used to identify prs safe to test on the integration environments label Apr 15, 2024
@cdiniz
Copy link
Collaborator

cdiniz commented Apr 15, 2024

Hi @pruoff, Thanks for the collaboration. We'll check the tests and merge the PR afterwards.

@github-actions github-actions bot removed the safe to test Label used to identify prs safe to test on the integration environments label Apr 15, 2024
@psousa50 psousa50 added the safe to test Label used to identify prs safe to test on the integration environments label Apr 15, 2024
@github-actions github-actions bot removed the safe to test Label used to identify prs safe to test on the integration environments label Apr 15, 2024
Copy link
Collaborator

@psousa50 psousa50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 👍

@psousa50 psousa50 merged commit 7187cfc into EqualExperts:master Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants