Skip to content

Commit

Permalink
Undoes last commit
Browse files Browse the repository at this point in the history
  • Loading branch information
Ata authored and Ata committed May 11, 2024
1 parent 9b27b16 commit bd1e664
Showing 1 changed file with 24 additions and 24 deletions.
48 changes: 24 additions & 24 deletions keyvault-argo.tf
Original file line number Diff line number Diff line change
Expand Up @@ -89,27 +89,27 @@ resource "kubernetes_service_account" "aks-argocd" {
}
}

# # Worked through this with Arturo at the tueaday live session.
# # Adds in the federated credential that was last created in Arturos script.
# # Not going to import this one as well.
# resource "azurerm_federated_identity_credential" "kubernetes-federated-credential" {
# name = "kubernetes-federated-credential"
# resource_group_name = azurerm_resource_group.equalvote.name
# subject = "system:serviceaccount:argocd:aks-argocd"

# depends_on = [
# azurerm_key_vault.equalvote-argocd,
# azurerm_user_assigned_identity.argocd-identity
# ]

# # Found this example that says we should be mapping to the ID and not principal_id
# parent_id = azurerm_user_assigned_identity.argocd-identity.id

# # Found this through the docuumentation here:
# # https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#oidc_issuer_url
# issuer = azurerm_kubernetes_cluster.equalvote.oidc_issuer_url

# # Found this wit Arturo through the CLI
# audience = ["api://AzureADTokenExchange"]

# }
# Worked through this with Arturo at the tueaday live session.
# Adds in the federated credential that was last created in Arturos script.
# Not going to import this one as well.
resource "azurerm_federated_identity_credential" "kubernetes-federated-credential" {
name = "kubernetes-federated-credential"
resource_group_name = azurerm_resource_group.equalvote.name
subject = "system:serviceaccount:argocd:aks-argocd"

depends_on = [
azurerm_key_vault.equalvote-argocd,
azurerm_user_assigned_identity.argocd-identity
]

# Found this example that says we should be mapping to the ID and not principal_id
parent_id = azurerm_user_assigned_identity.argocd-identity.id

# Found this through the docuumentation here:
# https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#oidc_issuer_url
issuer = azurerm_kubernetes_cluster.equalvote.oidc_issuer_url

# Found this wit Arturo through the CLI
audience = ["api://AzureADTokenExchange"]

}

0 comments on commit bd1e664

Please sign in to comment.