Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 21 decrease gaps between elements in the landing pages #710

Conversation

fsargent
Copy link
Collaborator

@fsargent fsargent commented Oct 21, 2024

Description

  • Removed huge gap value.

Screenshots / Videos (frontend only)

Old:
bettervoting com_ (1)
New:
CleanShot 2024-12-22 at 11 30 58@2x
CleanShot 2024-12-22 at 11 31 35@2x
CleanShot 2024-12-22 at 11 31 55@2x

Be sure to include both desktop and mobile views (mobile could be as low as 320 px wide)

Related Issues

For example, add fixes #10 to close issue #10

@ArendPeter
Copy link
Member

Thanks for the contribution!

The current size was chosen almost a year ago after a consultation with a ui/ux volunteer. The larger gap gives a simpler look since it has the focus on one thing at a time. But that said I also see how the added scrolling could hurt the experience.

Im open to recoconsidering that decision, but I wanted to clarify the original context :)

@fsargent
Copy link
Collaborator Author

Ok, so is there anything I can do to get this merged in then? Let me know!

@ArendPeter
Copy link
Member

ArendPeter commented Nov 14, 2024

Ok, so is there anything I can do to get this merged in then? Let me know!

Sorry for the delays! I think remove the font change, and making gap slightly larger (it went from 20 to 1, but I think something in the 3-5 range could still add some helpful separation). Then I'll merge add we'll see how we feel with it

For the STAR Ballot I noticed the new font caused the text to wrap so I think we should hold off on that

Edit: Actually on second thought, the wrapping might be because of the screen width, and not the font. I think the is the main stylistic change I'm nervous about. Once that's changed I'll merge both PRs

@fsargent fsargent force-pushed the 10-21-decrease_gaps_between_elements_in_the_landing_pages branch from 8bc2123 to 2f0afd4 Compare December 22, 2024 19:23
@fsargent
Copy link
Collaborator Author

@ArendPeter Finally fixed this up. I think it looks a lot better. Reverted the font changes and tried to be a bit more consistent about gaps at 2rem.

@ArendPeter ArendPeter merged commit aa7f9bb into Equal-Vote:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants