Add checkbox to ballot for reading instructions #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikefranze
requested changes
Dec 8, 2023
| {votingMethod == 'STAR_PR' && <StarPRBallotView/>} | ||
| {votingMethod == 'Plurality' && <PluralityBallotView/>} | ||
| {(votingMethod == 'RankedRobin' || votingMethod == 'IRV') && <RankedBallotView/>} | ||
| {votingMethod == 'Approval' && <ApprovalBallotView/>} |
There was a problem hiding this comment.
Nice, looks much cleaner
added 2 commits
December 8, 2023 14:56
mikefranze
reviewed
Dec 8, 2023
| const { id } = useParams(); | ||
| const [pages, setPages] = useState(makePages()) | ||
| const navigate = useNavigate(); | ||
| const [currentPage, setCurrentPage] = useState(0) | ||
|
|
||
| const setInstructionsRead = () => { | ||
| pages[currentPage].instructionsRead = true; |
There was a problem hiding this comment.
How does this work? pages should be immutable as a state
There was a problem hiding this comment.
Yeah, that operation alone won't trigger a refresh so that's why I call setPages
It's a bit hacky, but the alternative is to have a separate useState where I represent instructionsRead as an array and I'd need to do the same trick anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots / Videos (frontend only)
2023-12-08.13-59-46.mp4
Related Issues
fixes #405